Posting changes for review
You'll post changes to https://reviews.reviewboard.org through the RBTools command line suite. You should already have this set up.
Generally, assuming your Git branch is clean and is properly based off the master
branch, you can just run:
$ rbt post
This will post it on Review Board and provide the URL. Open that up, and make sure you do the following:
- Fill in the Description and Testing Done fields. Please be thorough, and read our guide on writing good change descriptions.
- Add "students" as a group (under Reviewers).
- Fill out the Bugs field with any bug numbers you're working on.
- Click View Diff and go through your code to do an initial self-review. If you see anything to fix up, you'll want to update your own code and then update the review request. We're going to ask you to fix it sooner or later, anyway.
- If your project isn't yet complete, and you know you have more work to do on it before you're ready for a final review, type "[WIP]" at the beginning of the Summary field.
When everything looks good, click Publish. We'll see it and review it!