In order to reduce the risk of landing new changes into the codebase, we're adopting some new procedures to follow when landing new code into the main repository.
Changes by core developers
- [ ] Change has at least one "Ship it!" from another core developer. Ship it must be for the latest diff revision (or "Fix it, then Ship it" with trivial issues)
- [ ] Merge branch with
rbt land
- [ ] Re-run Python and JavaScript unit tests, as appropriate. The entire suite should always be run before landing!
- [ ] Re-run manual tests
- [ ] Push
Third-party contributions (including students)
- [ ] Change has at least two "Ship It!"s on the latest diff revision from core developers. "Fix it, then Ship it" cannot be used
- [ ] If the code in question has a clear expert or owner, the change has to have had substantive review from that owner
- [ ] Apply patch with
rbt land
- [ ] Run Python and JavaScript unit tests, as appropriate. The entire suite should always be run before landing!
- [ ] Duplicate manual testing from review request.
- [ ] Push